Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SDK 1.0.63 #3479

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Update SDK 1.0.63 #3479

merged 1 commit into from
Nov 4, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Nov 4, 2024

No description provided.

@Velin92 Velin92 requested a review from a team as a code owner November 4, 2024 10:40
@Velin92 Velin92 requested review from pixlwave and removed request for a team November 4, 2024 10:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024 •
edited
Loading

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 9a5985a

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Velin92 Velin92 added the pr-misc for other changes label Nov 4, 2024
@Velin92 Velin92 enabled auto-merge (rebase) November 4, 2024 10:59
@codecov Codecov
Copy link

codecov bot commented Nov 4, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
848 1 847 0
View the top 1 failed tests by shortest run time 
PreviewTests test_joinRoomScreen()
Stack Traces | 6.48s run time 
failed - Snapshot "Unknown" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_joinRoomScreen-iPhone-16-en-GB.Unknown.png"
@+
"file:.../tmp/PreviewTests/test_joinRoomScreen-iPhone-16-en-GB.Unknown.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.966095 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@Velin92 Velin92 merged commit c34e3e8 into develop Nov 4, 2024
9 checks passed
@Velin92 Velin92 deleted the mauroromito/update_sdk_1.0.63 branch November 4, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
pr-misc for other changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Velin92 @pixlwave